-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi] Minor improvements for my bridges #1507
Conversation
The rest LGTM. |
Just added one more commit for AnimeUltime, similar to LeMondeInformatique:
@somini Any issue with this PR? "The rest" suggests something may be missing in your message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@somini Any issue with this PR? "The rest" suggests something may be missing in your message.
I meant besides the other comments I did.
Thanks @somini, I could not see your comments until your last reply. I'll address them. |
(guid is valid uri AND item uri is not valid) => (guid is valid uri AND item uri is empty or not valid)
TheHackerNews - ok FeedExpander and Markdown fixes - ok I would merge this PR immediately if it didn't have Next Inpact commit. I suggest to take it external PR |
Was previously needed due to actual encoding on the page being inconsistent with encoding specified in <meta> tag
Was previously needed due to encoding on the page being incorrect
Thanks for your time in reviewing my pull requests 👍 |
Thanks @ORelio ! |
Hi,
Here are a few improvements for the bridges I am maintaining:
Anidex: Use alternate domain name to circumvent ddos-guardNextInpact: Fix article subtitle extractionReleases3DS: Allow monitoring Nintendo Switch releases as wellAlso two minor fixes to the RSS-Bridge core:
Changes are minor so I grouped them into a single Pull request. Hope you don't mind.
EDIT: As requested by @em92 in #1692, changes for
Anidex
andReleases3DS
were removed from this PR.EDIT: Also removed changes for
NextInpact
as the bridge is being reworked (#1692)