[Configuration.php] Fix notice of undefined offset when in detached HEAD state. #1569
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a clone is in a detached HEAD state (e.g. when a tag is checked out), the format of the .git/HEAD file is different and contains an hash only. This means there is nothing to
explode()
and the array access fails, producingNotice: Undefined offset: 3 in <path>\Configuration.php on line 247
. This PR fixes this by checking if the array element exists and is not NULL.Steps to reproduce:
git clone https://github.com/RSS-Bridge/rss-bridge.git .
git checkout tags/2020-02-26
(.git/HEAD contains "0705a2e7bb391d2eac707bb1d195e51f5911b334" now)