[BridgeXPathAbstract + BlizzardNewsBridge + XPathBridge] Add new abstract class + two example implementations #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niehztog
force-pushed
the
abstract_xpath_bridge
branch
7 times, most recently
from
56534ff to
b731162
Compare
|
Also, you don't need to rebase and force push. You commits will be squashed after merging. |
Niehztog
force-pushed
the
abstract_xpath_bridge
branch
from
b731162 to
782b1c0
Compare
|
Hello @em92 |
Niehztog
force-pushed
the
abstract_xpath_bridge
branch
from
782b1c0 to
baa55a7
Compare
|
Hi, @Niehztog ! Could you please rebase your PR? In mid october I have fixed Travis CI for automatic PR checks. It stopped working in August. |
…implementations (BlizzardNewsBridge + XPathBridge)
…implementations (BlizzardNewsBridge + XPathBridge)
…implementations (BlizzardNewsBridge + XPathBridge)
…implementations (BlizzardNewsBridge + XPathBridge)
Niehztog
force-pushed
the
abstract_xpath_bridge
branch
from
895f4a8 to
c6da4da
Compare
em92
approved these changes
Nov 8, 2020
|
gj @Niehztog |
dvikan
reviewed
Mar 28, 2022
| */ | ||
| protected function fixEncoding($input) | ||
| { | ||
| return $this->getParam('fix_encoding') ? utf8_decode($input) : $input; |
There was a problem hiding this comment.
I think this should be utf8_encode() which would convert iso-8859 to utf8. Right now it's the other way around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a reaction to the discussion in my original pull request, where user @somini suggested to provide an abstract bridge simplifying the creation of new bridges using xpath expressions, I developed this new proposal as a pull request.
Basically I divided the code of my original pull request into three different classes: One abstract class "BridgeXPathAbstract" and two derived classes "BlizzardNewsBridge" and "XPathBridge" demonstrating how to use it. This approach has two great advantages:
Contents:
This PR can be regarded as an alternative approach to 1645.
If desired I would be totaly okay with removing XPathBridge from the PR. I left it here for quick debugging of new xpath expressions without the need to create a new bridge class.