Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ParameterValidator] Ignore cache-busting param [#1701] #1723

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

JasonGhent
Copy link
Contributor

@JasonGhent JasonGhent commented Aug 31, 2020

This PR addresses #1701

Describe the bug
Some readers implement cache-busting logic in the form of appending a &_= query parameter to sequential requests. Appropriately, this is interpreted by the BridgeAbstract as a parameter to pass to the bridge. Unfortunately, this breaks some bridges.

To Reproduce
Steps to reproduce the behavior:

  • Append &_=123 to any bridge request.
  • See error:
 Exception: Invalid parameters value(s): _ in /app/lib/error.php:24\nStack trace:\n#0 /app/lib/error.php(33): returnError(
)\n#1 /app/lib/BridgeAbstract.php(222): returnClientError()\n#2 /app/actions/DisplayAction.php(133): BridgeAbstract->setDatas()\n#3 /app/index.php(38): DisplayAction->execute()\n#4 {main}

Expected behavior
The bridge abstract should ignore unexpected parameters. Or strip cache-busting earlier in the execution process.

Desktop (please complete the following information):

    OS: MacOS
    Browser Firefox, Chrome, Safari
    Version latest

@JasonGhent JasonGhent changed the title [ParameterValidator] Ignore cache-busting param [ParameterValidator] Ignore cache-busting param [#1701] Sep 13, 2020
@em92 em92 linked an issue Sep 14, 2020 that may be closed by this pull request
@em92 em92 merged commit 3a29347 into RSS-Bridge:master Sep 14, 2020
@em92
Copy link
Contributor

em92 commented Sep 14, 2020

gj @JasonGhent !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache busting parameters from RSS readers break bridges
2 participants