[RedditBridge] Rewrite to use JSON #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, but I get some errors with the "selfhosted" example: |
|
LGTM, but Travis complains about a function missing in PHP 7.2, which is already abandoned years ago: https://travis-ci.com/github/RSS-Bridge/rss-bridge/jobs/401740548#L556 |
|
Hi, @dawidsowa ! |
|
Ok, that fixes it. |
|
gj @dawidsowa ! |
|
Works well, thank you! How hard would it be to implement the same function for users also, e.g: |
|
Data structure seems to be the same, so it should be easy. |
|
Wonderful, looking forward, thanks @dawidsowa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes use of fact, that you can append
.jsonto reddit url, to get it's JSON representation.For example https://reddit.com/r/selfhosted/.json.
It's works, but I'm not sure if I've taken care of all possible content.
Fixes #1525