Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EconomistBridge] Fixes for fetching new page structure #1836

Merged
merged 8 commits into from
Nov 29, 2020
Merged

[EconomistBridge] Fixes for fetching new page structure #1836

merged 8 commits into from
Nov 29, 2020

Conversation

thefranke
Copy link
Contributor

A bunch of fixes that make pulling articles possible again.

@SpangleLabs SpangleLabs mentioned this pull request Nov 5, 2020
Closed
@em92
Copy link
Contributor

em92 commented Nov 9, 2020

Hi, @thefranke ! Please fix following errors from Travis CI:

FILE: /home/travis/build/RSS-Bridge/rss-bridge/bridges/EconomistBridge.php

--------------------------------------------------------------------------------

FOUND 3 ERRORS AFFECTING 3 LINES

--------------------------------------------------------------------------------

 22 | ERROR | [x] String "http" does not require double quotes; use single

    |       |     quotes instead

 28 | ERROR | [x] String "img" does not require double quotes; use single

    |       |     quotes instead

 38 | ERROR | [x] String "The Economist" does not require double quotes; use

    |       |     single quotes instead

@em92 em92 merged commit 56eb829 into RSS-Bridge:master Nov 29, 2020
@em92
Copy link
Contributor

em92 commented Nov 29, 2020

gj @thefranke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thefranke @em92