Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlickrBridge] Add content option to By username #1861

Merged
merged 2 commits into from
Mar 29, 2022
Merged

[FlickrBridge] Add content option to By username #1861

merged 2 commits into from
Mar 29, 2022

Conversation

VerifiedJoseph
Copy link
Contributor

Adds option to return user's uploads or favorites. Defaults to uploads.
Untitled12

@Bockiii
Copy link
Contributor

Bockiii commented Mar 26, 2022

🤖 Pull request artifacts

file commit
pr4-Flickr-current-context1.html 51e6863655ea903b2129e7aacd5941457d21d447
pr4-Flickr-current-context2.html 51e6863655ea903b2129e7aacd5941457d21d447
pr4-Flickr-current-context3.html 51e6863655ea903b2129e7aacd5941457d21d447
pr4-Flickr-pr-context1.html 51e6863655ea903b2129e7aacd5941457d21d447
pr4-Flickr-pr-context2.html 51e6863655ea903b2129e7aacd5941457d21d447
pr4-Flickr-pr-context3.html 51e6863655ea903b2129e7aacd5941457d21d447

@Bockiii
Copy link
Contributor

Bockiii commented Mar 26, 2022

Would it be possible to grab the post date and put it into the timestamp?

@Bockiii
Copy link
Contributor

Bockiii commented Mar 26, 2022

I know this happened before as well, but maybe you are up to fix it: It looks like the post content is not 100% correct.

If you look at the context1 link, you can see that in the first post, a " sign is translated to %u201

Tell me if you want to fix it or merge it like it is.

@Bockiii
Copy link
Contributor

Bockiii commented Mar 29, 2022

If you are up for a fix, you can just do it in a new PR. This here works, the comments can be handled in enhancements.

@Bockiii Bockiii merged commit a485bea into RSS-Bridge:master Mar 29, 2022
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants