[GenshinImpactBridge] Add bridge (fix #1889) #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
gj @corenting ! |
|
https://genshin.mihoyo.com/content/yuanshen/getContentList?pageSize=3&pageNum=1&channelId=10 follows the timezone UTC+8 but is unspecified in the json. It would be better to specify a timezone since RSS-bridge uses UTC+0 by default and the feed currently has mismatched timestamps with articles when used with a feed reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bridge requested in #1889.
it should include all the requested content. I also added enclosures for the article banner if available for the article.
I reduced the number of fetched articles from 5 to 3 because an additional call per article is needed to fetch the full content.