Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RedditBridge]: Add user option #1943

Merged
merged 5 commits into from
Feb 23, 2021
Merged

[RedditBridge]: Add user option #1943

merged 5 commits into from
Feb 23, 2021

Conversation

dawidsowa
Copy link
Contributor

Implements option to fetch content from https://www.reddit.com/user/username/.json.

By default comments are filtered out.

@kinoushe

@kinoushe
Copy link

Wonderful, works as described! The comment filtering will be especially handy.

Just one small suggestion I have, could we wrap each image in a block level element, e.g. p:

$images[] = '<p><img src="' . $src . '"/></p>';

This will help with presentation by adding vertical margins between multiple images.

@dawidsowa
Copy link
Contributor Author

How about using <figure> instead of <p>?

@kinoushe
Copy link

kinoushe commented Jan 19, 2021

Sounds good, <figure> was my initial thought, but noticed <p> was used in the twitter bridge.

I've just tested <figure> and it works as expected, so that would be the better choice.

@kinoushe
Copy link

Have been using this PR for a few days and it's working well, thanks again!

@SpangleLabs
Copy link
Contributor

Sounds like this PR is good to merge then? @em92

Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @dawidsowa ! Please fix following notices:
https://feed.eugenemolotov.ru/pr1943/?action=display&bridge=Reddit&context=user&u=Nythious&comments=on&format=Html

Notice: Undefined property: stdClass::$link_flair_text in /var/www/rss-bridge/pr1943/bridges/RedditBridge.php on line 103

Notice: Undefined property: stdClass::$pinned in /var/www/rss-bridge/pr1943/bridges/RedditBridge.php on line 104

Notice: Undefined property: stdClass::$spoiler in /var/www/rss-bridge/pr1943/bridges/RedditBridge.php on line 106

@em92 em92 merged commit 569276f into RSS-Bridge:master Feb 23, 2021
@em92
Copy link
Contributor

em92 commented Feb 23, 2021

gj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants