Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BridgeImplementationTest] Allow multiple contexts to have empty parameter arrays #1954

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[BridgeImplementationTest] Allow multiple contexts to have empty parameter arrays #1954

merged 1 commit into from
Aug 10, 2021

Conversation

VerifiedJoseph
Copy link
Contributor

@VerifiedJoseph VerifiedJoseph commented Jan 23, 2021

Currently if multiple contexts have an empty parameters array the test fails and reports duplicate parameters found, which is not the case. This pull request updates testParameters() in BridgeImplementationTest.php to allow multiple contexts to have an empty parameters array.

@em92
Copy link
Contributor

em92 commented Aug 10, 2021

Looks like it is the case: #2129

@em92 em92 merged commit 4529e36 into RSS-Bridge:master Aug 10, 2021
@VerifiedJoseph
Copy link
Contributor Author

Looks like it is the case: #2129

also the case with #1951.

@em92
Copy link
Contributor

em92 commented Aug 10, 2021

also the case with #1951.

I see. Could please also rebase that PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants