[style] add dark mode #2029
Merged
[style] add dark mode #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@em92 what do you think? Yay or nay? |
|
Does this only apply to the website or also to the feed items if you retrieve the feed in a feed reader? If it's just the website: yes please! |
It only applies to the RSS-Bridge site. Feed items do not contain any styling. |
|
Extra effort : is it possible to display a slider on the site (top right corner for example) to do the switcheroo? My quick search found a few css-only sliders that dont use js. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2011
This PR adds a dark mode to RSS-Bridge. The dark mode will automatically be used when the users OS is set to a dark theme, using
@media (prefers-color-scheme: dark). This way, the dark mode only gets applied to users who actually prefer dark themes.darkmode.mp4