Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Formula1Bridge] New bridge #2085

Merged
merged 2 commits into from
May 6, 2021
Merged

[Formula1Bridge] New bridge #2085

merged 2 commits into from
May 6, 2021

Conversation

axor-mst
Copy link
Contributor

Hello,

Feed on the official Formula 1 website stopped working a few days ago, which created a perfect opportunity to fix it with a new bridge. There are two things about it worth mentioning:

  • I am not yet sure whether the API key changes over time or stays the same - for now I have hardcoded it and will keep monitoring the website
  • LIMIT_MAX is set to 100 even though the API theoretically allows up to 1000, the reason is that responses longer than 7340032 bytes are not returned and instead an error message is generated

bridges/Formula1Bridge.php Outdated Show resolved Hide resolved
@axor-mst axor-mst requested a review from em92 April 27, 2021 06:13
@axor-mst
Copy link
Contributor Author

axor-mst commented May 6, 2021

After 10 days the API key is still the same and therefore the bridge still works correctly.

@em92 em92 merged commit 378f78d into RSS-Bridge:master May 6, 2021
@em92
Copy link
Contributor

em92 commented May 6, 2021

gj @AxorPL !
Btw, I have just payed attention, that you are using getContents() or returnServerError() combination. I suggest not to use returnServerError as it is useless. Discussion: #2082 (review)

@axor-mst
Copy link
Contributor Author

axor-mst commented May 7, 2021

Thanks, will remove it in the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants