-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ParksOnTheAir] New bridge #2086
Conversation
e2344da
to
3e2f05c
Compare
https://api.pota.us/spot/activator doesn't return anything useful. Api not working? |
The ParksOnTheAir api provides real-time spots of operators as reported by users. If there are no user reports then this API will return an empty list. I just checked this endpoint and got:
|
Is the cache timeout of 1 minute actually necessary? Do you know how long the entries stay in the api? |
I'm torn. On the one hand, the bridge works and probably does what it's supposed to do. I can summise that from the code and the website behind it. On the other hand, this bridge will return 0 items 99.99% of the time, which makes it a biiiitch for automated testing (no result is usually not a good sign) and also for just general use. If I'm a user, starting off with this bridge, I would not be confident that the bridge works, as... there is no feed at all. I think it would make more sense to crawl the "activations" page and put those scheduled objects into items, but I think they are dynamic, so it will require some additional work. I haven't landed on one or the other yet. What do others think? @yamanq @dvikan @em92 @VerifiedJoseph |
https://api.pota.app/spot/activator is the endpoint used by pota.app, which is the link I get to when I click "POTA Spots" on the parksontheair.com page. While the api.pota.us endpoint returns null, this one returns many more results for me. If this endpoint is also empty at times, one solution could be generating a static feed item when there are no results but the request status code is 200. It would have the same uid every time so that RSS clients could keep the item out of view. Regarding the cache timeout, I think it is fine considering the POTA webapp refreshes its own data (including several more API calls than just /spot/activator) every 60 seconds too. |
https://api.pota.app/spot/activator provides the real-time spots. I believe the other API that you found contains the scheduled activations. They aren't taken as seriously because not everyone follows through on their planned activations. It's more beneficial to get a feed of people that are actually confirmed to be on the air. The 60 second cache timeout was set to not overload the API. There is no need to have second-to-second updates. There is no need for someone to pounce on the a new activator. The activators stay on for quite a while, up to hours. Additionally if someone ends their activation and it still appears then the user, worst case, would lose a couple seconds tuning into that frequency and realizing no one was on the air anymore. |
? You're using "pota.us" in the code and "pota.app" in your comment. Which is it? |
Pull request artifacts
|
My apologies, I missed this. |
Ah, now it makes more sense. Please fix all of the check-errors and then I think we can merge this |
aebfd26
to
90a202e
Compare
90a202e
to
7be3110
Compare
Sorry it took a little bit to figure out all these linting rules. I think we should be good now. Thanks for the help everyone! |
Parks On The Air is an amateur radio event. The POTA website offers a spotting network to see who's activating what parks and where. This bridge utilizes the spotting network's JSON api to return as an RSS feed.