[PixivBridge] Rewrite Bridge #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em92
suggested changes
May 17, 2021
There was a problem hiding this comment.
Hi, @yamanq!
https://feed.eugenemolotov.ru/pr2111/?action=display&bridge=Pixiv&mode=illustrations%2F&tag=doom&posts=10&fullsize=on&format=Html
"On the death road" image does not seem to be fullsize.
bridges/PixivBridge.php
Outdated
|
|
||
| public function collectData() { | ||
| $content = getContents($this->getSearchURI()) | ||
| or returnClientError('Unable to query pixiv.net'); |
There was a problem hiding this comment.
getContents raises exception on non 200 http result. No need to use returnClientError.
bridges/PixivBridge.php
Outdated
| } | ||
| file_put_contents($path . '/' . $illustId . '.jpeg', $illust); | ||
| file_put_contents($path . '/' . $illustId . '.jpg', $illust); |
There was a problem hiding this comment.
if $illustId's value is ../../../../etc/rc.local it could be possible to write outside rss-bridge directory.
You need to escape this situation.
|
Thanks for the review @em92. I believe all 3 issues are fixed now. I can squash the commits after they are approved. |
|
gj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the bridge to use the new site format and added some options:
Closes #1807
Closes #1258