Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppleMusicBridge] Complete rebuild for new site #2134

Merged
merged 1 commit into from
May 30, 2021

Conversation

Bockiii
Copy link
Contributor

@Bockiii Bockiii commented May 26, 2021

Fixes #2132

I have no comparison how the old output looked like, but this looks reasonable.

image

@Bockiii Bockiii force-pushed the applemusic branch 2 times, most recently from 69980a9 to 2680753 Compare May 27, 2021 10:18
@jacquesh
Copy link
Contributor

Oh excellent, thanks for this!

It manages to successfully retrieve artist history and produce a valid feed, but I am getting this error on the web view page:
image

For reference here is what I see with this update (viewed in FreshRSS):
image
versus what I got for the same album previously:
image

@Bockiii
Copy link
Contributor Author

Bockiii commented May 27, 2021

The search I am using only provides the 60px and 100px versions of the cover and tbh, for an RSS feed I think thats sufficient. No one needs the full 1080 version of a cover in an rss item.

As for the error: I looked up Rise Against and didnt get any error.

?action=display&bridge=AppleMusic&artist=16252655&limit=10&format=Html

Thats the query I was using. What are you using to provoke the error message?

Greetings

@em92
Copy link
Contributor

em92 commented May 27, 2021

What are you using to provoke the error message?

Error message appears on debug mode. Create empty file with name "DEBUG" in rss-bridge root directory

@em92
Copy link
Contributor

em92 commented May 27, 2021

Also please fix linting

@jacquesh
Copy link
Contributor

The search I am using only provides the 60px and 100px versions of the cover and tbh, for an RSS feed I think thats sufficient. No one needs the full 1080 version of a cover in an rss item.

@Bockiii Sure, I only provided comparison screenshots because you mentioned you weren't sure what it looked like previously. I have no problem with providing only 60/100px versions of the cover. :)

@Bockiii Bockiii force-pushed the applemusic branch 2 times, most recently from 6a9cc52 to 2a5eed9 Compare May 27, 2021 23:06
@Bockiii
Copy link
Contributor Author

Bockiii commented May 27, 2021

@em92 Fixed linting, even though I think now it's harder to read but okay...
The only thing not fixed is the "line too long" as that would make it even harder to read.

@jacquesh understood, thanks :)

Also, the debug message should also be fixed.

@jacquesh
Copy link
Contributor

Can confirm, I no longer see the debug error message

@Bockiii
Copy link
Contributor Author

Bockiii commented May 29, 2021

@em92 Also fixed the long line, no issues anymore. Can be merged

@em92 em92 merged commit b074abc into RSS-Bridge:master May 30, 2021
@em92
Copy link
Contributor

em92 commented May 30, 2021

gj @Bockiii !
FYI, when I accept PRs, all commits are squashed into one, so you don't need to force push.

@Bockiii
Copy link
Contributor Author

Bockiii commented May 30, 2021

Very good information :D I will stop doing it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Music bridge is broken, seems unable to find expected page elements
3 participants