-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReutersBridge] Change timestamp, add new feed, add alt text to image. #2150
Conversation
csisoap
commented
Jun 7, 2021
•
edited
Loading
edited
- Change timestamp for each article from modified date to published date.
- Add new 'Fact Check' feed.
- Add support for Twitter, Youtube, Instagram embed.
- Add alt text for each images (not include those chart/graphic).
- Add new wireitem template type and change the code on line 233 to use the extracted data instead of original one. - Refactor some codebase.
- Change timestamp for each article from modified date to published date. - Add new 'Fact Check' feed. - Add support for Twitter embed. - Add alt text for each images (not include those chart/graphic).
…to image." This reverts commit 5a7b7d8.
- Change timestamp for each article from modified date to published date. - Add new 'Fact Check' feed. - Add support for Twitter embed. - Add alt text for each images (not include those chart/graphic).
- Use switch case instead of if else on line 212. - Add support for Youtube, Instagram embed.
I suggest to use multi line strings instead of those indents. Here is an example rss-bridge/bridges/InternetArchiveBridge.php Lines 138 to 141 in 76c3833
|
I don't think problem is about closing tags. Actually iframes are escaped: rss-bridge/lib/FormatAbstract.php Lines 176 to 183 in ecaae73
|
I think what make iframe not working is this: |
Ok, I will accept it as is. Good job! |