Update nordbayern #2169
Merged
Update nordbayern #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em92
suggested changes
Jun 20, 2021
bridges/NordbayernBridge.php
Outdated
Comment on lines
59
to
65
| private function fixLinksInElement($element) { | ||
| foreach($element->find('a') as $a) { | ||
| if(self::startsWith($a->href, '/')) { | ||
| $a->href = 'https://nordbayern.de' . $a->href; | ||
| } | ||
| } | ||
| } |
bridges/NordbayernBridge.php
Outdated
| 'Rothenburg o.d.T.' => 'rothenburg-o-d-t', | ||
| 'Schwabach' => 'schwabach', | ||
| 'Rothenburg o.d.T.' => 'rothenburg-ob-der-tauber', |
There was a problem hiding this comment.
Old feed urls with these params will become invalid if following change is accepted. Can we escape it?
|
Also please fix phpcs errors |
find articles get raw articles include images again fix serveral bugs catch all articles fix links try to exlucde polizeimeldungen try to fix weird html fix ident make code php7 compatible apply requested changes fix phpcs error
theScrabi
force-pushed
the
update_nordbayern
branch
from
3f8d732 to
6d08d54
Compare
|
bump 😅 |
|
gj @theScrabi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nordbayern changed the whole layout and design. This is the new adaptation.