Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NationalGeographicBridge] Rewrite bridge #2177

Merged
merged 16 commits into from
Oct 1, 2021
Merged

[NationalGeographicBridge] Rewrite bridge #2177

merged 16 commits into from
Oct 1, 2021

Conversation

csisoap
Copy link
Contributor

@csisoap csisoap commented Jun 23, 2021

  • All the option will be preserved.
  • Add timestamp, author's name included with full article.

Fix #2068

@csisoap csisoap marked this pull request as draft June 26, 2021 12:47
csisoap added 3 commits June 30, 2021 13:02
- Add new content type.
- Remove some content id to avoid duplicate article in the feed.
- Remove some redundant code.
- Modify function handleImages().
… of the article

- Fix linting.
- Add description to the beginning of the full article.
@csisoap csisoap marked this pull request as ready for review June 30, 2021 06:24
@em92
Copy link
Contributor

em92 commented Jul 20, 2021

Please fix warnings and notices: https://feed.eugenemolotov.ru/pr2177/?action=display&bridge=NationalGeographic&context=By+Topic&topic=magazine&full=on&format=Html

Also, feel free to set yourself as maintainer for this bridge. Current one is inactive.

@em92 em92 merged commit 8bcf4eb into RSS-Bridge:master Oct 1, 2021
floviolleau pushed a commit to floviolleau/rss-bridge that referenced this pull request Jan 25, 2022
- All the option will be preserved.
- Add timestamp, author's name included with full article.
@csisoap csisoap deleted the natgeo branch December 18, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

National Geographic bridge is broken
2 participants