[PicukiBridge] Displays Instagram Posts #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative Instagram Bridge
em92
suggested changes
Jun 25, 2021
There was a problem hiding this comment.
Hello, @marcus-at-localhost !
Looks like it works.
Please fix linting (must work on php 5.6) and other review comments.
bridges/PicukiBridge.php
Outdated
| public function collectData() | ||
| { | ||
| $html = getSimpleHTMLDOM($this->getURI()) | ||
| or returnServerError('Could not request Picuki.'); |
There was a problem hiding this comment.
You don't need this. getSimpleHTMLDom will throw exception.
bridges/PicukiBridge.php
Outdated
| public function getURI() | ||
| { | ||
| if (!is_null($this->getInput('u'))) { | ||
| return trim(self::URI, '/') . '/profile/' . $this->getInput('u'); |
bridges/PicukiBridge.php
Outdated
| } | ||
|
|
||
| if (!is_null($this->getInput('h'))) { | ||
| return trim(self::URI, '/') . '/tag/' . $this->getInput('h'); |
bridges/PicukiBridge.php
Outdated
| } | ||
|
|
||
| if (!is_null($this->getInput('h'))) { | ||
| return trim(self::URI, '/') . '/tag/' . $this->getInput('h'); |
There was a problem hiding this comment.
That would be nice, if example_hash_tag is accepted the same like #example_hash_tag
bridges/PicukiBridge.php
Outdated
Comment on lines
85
to
89
| if (!is_null($this->getInput('u'))) { | ||
| return $this->getInput('u') . ' - Picuki Bridge'; | ||
| } | ||
|
|
||
| return parent::getName(); |
php 5.6 compat add `urljoin` better hashtag handling
|
gj! |
|
@marcus-at-localhost any plans to add stories as @dhuschde suggested? If not, I suggest to @dhuschde to make an feature request as an issue. |
|
Thanks @em92! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative Instagram Bridge