[YoutubeBridge] Fix bridge #2208

csisoap · 2021-07-10T09:15:28Z

Add support for custom channel name (as request [YoutubeBridge] Channel slug input support #2206).
Add new method to fetch JSON data.
Search, listing now parsing data through JSON, HTML is not work anymore.
~~Remove page number input on the Search endpoint.~~
Merge two parseJSON function into one.
~~Add ability to get better timestamp.~~
Fix regex on duration limit.
Add anchor on some link in the description text.
Add URL on the getURI() for each context.
UPDATE 20/07/2021:
~~Add support for Youtube Data API v3.~~ => Temporary remove API support, going to create a new PR after this PR merged.
Fix playlists that have more than 15 items not display correctly.
Add new custom name parameter.
Fix sorting on playlist not function correctly if use API.
Fix duration when try to get timestamp from Premiering video. (I haven't tested this on API)
Update regex for URL.

Notes: This bridge will handle the case like Video, Livestream. Other videos like Premiering stuff not tested.

- Add support for custom channel name. - Add new method to fetch JSON data. - Search, listing now parsing data through JSON, HTML is not work anymore. - Remove page number input on the Search endpoint.

This reverts commit 589c918.

- Merge two parseJSON into one. - Remove ytBridgeParseHtmlParsing() due to YouTube not populating HTML in the first run. - Add ability to get better timestamp. - Handle the case of 'Livestream' video.

em92

Empty feed if using search. https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=Search+result&s=Front+Mission+3&duration_min=&duration_max=&format=Html

Playlist stopped working.
Before PR: https://feed.eugenemolotov.ru/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLJYf0JdTApCqAbZImkQagXEuByh-b_7To&duration_min=&duration_max=&format=Html
After PR: https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLJYf0JdTApCqAbZImkQagXEuByh-b_7To&duration_min=&duration_max=&format=Html

em92 · 2021-07-12T18:55:29Z

bridges/YoutubeBridge.php

-			),
-			'pa' => array(
-				'name' => 'page',
-				'type' => 'number',
-				'exampleValue' => 1


Deleting this parameter will make previous generated feed links invalid. As for now, I suggest to leave it as for now.

@em92 I've pushed new commit that fixed.

- Fix condition error that make some feed stop working. - Fix feed name in the search feed. - Add back the page number parameter on the search feed.

em92 · 2021-07-13T18:22:21Z

https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w&duration_min=&duration_max=&format=Html

Item timestamps are incorrect. All videos show July 13 (today) with different years.

Previous version of timestamp fetching worked fine. Isn't it?

em92 · 2021-07-13T18:30:40Z

bridges/YoutubeBridge.php

+			$count++;
+			if($count == 20) {
+				break;
+			}


Playlist can have videos sorted by ascending (oldest first) upload date. This construction will ignore latest videos, which is not good.

For example: https://www.youtube.com/playlist?list=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w

csisoap · 2021-07-14T02:47:39Z

https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w&duration_min=&duration_max=&format=Html

Item timestamps are incorrect. All videos show July 13 (today) with different years.

Previous version of timestamp fetching worked fine. Isn't it?

I looked into the video, for example like this: https://www.youtube.com/watch?v=UP091FeB-3o and see the timestamp is 2 years ago 15 minutes after extracted. So that why you see all videos show today with different years.

csisoap · 2021-07-14T03:50:51Z

I'm going to remove those timestamp and set it back to use the meta timestamp instead.
The only way to get the corrected timestamp beside RSS feed is to using API from YouTube.

…ta, set timestamp back to those in meta tag.

em92 · 2021-07-20T07:50:41Z

Add support for custom channel name

This must be implemented as the other context, not as "User". For example, these channels are different:
https://www.youtube.com/c/DeathmatchTV
https://www.youtube.com/user/DeathmatchTV

Everything else looks good and ready to be merged once resolved issue above.

- Add support for Youtube Data API v3. - Fix playlists that have more than 15 items not display correctly. - Add new custom name parameter. - Fix sorting on playlist not function correctly if use API.

…avoid repeat it

csisoap · 2021-07-28T08:16:47Z

Temporary marking this as draft until PR #2100 is merged

em92 · 2021-07-28T08:44:12Z

hi, @csisoap!
How is this PR related to that PR? That PR btw is blocked by other (droping support of php 5.6 and 7.0)

csisoap · 2021-07-28T10:09:54Z

hi, @csisoap!
How is this PR related to that PR? That PR btw is blocked by other (droping support of php 5.6 and 7.0)

Hi @em92, this PR does supported Youtube Data API v3, which requires an API key. And that PR supported using environment variable for the bridge. I'm intent to add support for getting API key from environment variable once that PR is merged to avoid people accidently commited to the public repo.

em92 · 2021-09-05T03:39:19Z

hi again, @csisoap!
Could you please temporary take out Youtube Data API v3 support and add new PR after I merge this PR? There are other some good features and fixes that you implemented. #2100 problably will be long to accept since RSS-Bridge needs to drop php 5.6 and 7.0.

After you take that API usage out, I will check PR again and, if everything works fine, I will accept it.

csisoap · 2021-09-06T08:20:41Z

You can merge it now, @em92

em92

Following links return empty feed:
https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=Search+result&s=Front+Mission+3&duration_min=&duration_max=&format=Html (search)
https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w&duration_min=&duration_max=&format=Html (playlist)

Current version returns non-empty playlist: https://feed.eugenemolotov.ru/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w&duration_min=&duration_max=&format=Html

csisoap · 2021-09-09T09:18:50Z

Following links return empty feed:
https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=Search+result&s=Front+Mission+3&duration_min=&duration_max=&format=Html (search)
https://feed.eugenemolotov.ru/pr2208/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w&duration_min=&duration_max=&format=Html (playlist)

Current version returns non-empty playlist: https://feed.eugenemolotov.ru/?action=display&bridge=Youtube&context=By+playlist+Id&p=PLaDrN74SfdT7Ueqtwn_bXo1MuSWT0ji2w&duration_min=&duration_max=&format=Html

Oops, my bad. Sorry about that. I've pushed a commit that resolve this.

em92 · 2021-09-11T08:20:21Z

gj!

csisoap added 10 commits July 10, 2021 16:09

[YoutubeBridge] Fix bridge

076e6ad

- Add support for custom channel name. - Add new method to fetch JSON data. - Search, listing now parsing data through JSON, HTML is not work anymore. - Remove page number input on the Search endpoint.

[YoutubeBridge] Fix getURI()

589c918

Revert "[YoutubeBridge] Fix getURI()"

a787633

This reverts commit 589c918.

[YoutubeBridge] Fix getURI()

78026b9

[YoutubeBridge] Fix lint

1adaf6e

[YoutubeBridge] Fix getURI(), fix regex

fbe2ff5

[YoutubeBridge] Fix edge case, add anchor to description

e8bf849

[YoutubeBridge] Fix lint

6199164

[YoutubeBridge] Add target=_blank for anchor tag

d4dfe56

[YoutubeBridge] Fix YouTube subscribe URL being parsed, not redirect URL

7413f41

csisoap marked this pull request as draft July 11, 2021 11:51

csisoap added 3 commits July 11, 2021 19:13

[YoutubeBridge] Add better timestamp, fix typo

0cb169c

[YoutubeBridge] New change

603ecbb

- Merge two parseJSON into one. - Remove ytBridgeParseHtmlParsing() due to YouTube not populating HTML in the first run. - Add ability to get better timestamp. - Handle the case of 'Livestream' video.

[YoutubeBridge] Add support for more URL type on Youtube

0d13b1f

csisoap marked this pull request as ready for review July 12, 2021 03:22

em92 linked an issue Jul 12, 2021 that may be closed by this pull request

[YoutubeBridge] Channel slug input support #2206

Closed

em92 suggested changes Jul 12, 2021

View reviewed changes

[YoutubeBridge] New fix

8c30d34

- Fix condition error that make some feed stop working. - Fix feed name in the search feed. - Add back the page number parameter on the search feed.

em92 suggested changes Jul 13, 2021

View reviewed changes

csisoap added 3 commits July 14, 2021 11:02

[YoutubeBridge] Remove codes extracted timestamp from accessibilityDa…

0806483

…ta, set timestamp back to those in meta tag.

[YoutubeBridge] Fix indent

6d23fba

[YoutubeBridge] Remove counter

ea7ad8d

csisoap added 4 commits July 20, 2021 16:19

[YoutubeBridge] New change

29bc0f3

- Add support for Youtube Data API v3. - Fix playlists that have more than 15 items not display correctly. - Add new custom name parameter. - Fix sorting on playlist not function correctly if use API.

[YoutubeBridge] Fix lint

a56c906

[YoutubeBridge] Fix lint

4132459

[YoutubeBridge] Remove unused variable

246ff7f

[YoutubeBridge] Add feed name for custom name, move some codebase to …

ac8cc80

…avoid repeat it

csisoap marked this pull request as draft July 28, 2021 08:16

em92 linked an issue Aug 30, 2021 that may be closed by this pull request

YouTube Feed failed to generate with error 0 #2256

Closed

[YoutubeBridge] Remove support for YouTube Data API v3

cf8fc9e

csisoap marked this pull request as ready for review September 6, 2021 08:20

em92 suggested changes Sep 8, 2021

View reviewed changes

[YoutubeBridge] Fix no results were displayed after scraping.

311773b

em92 merged commit a264085 into RSS-Bridge:master Sep 11, 2021

csisoap deleted the youtube branch September 11, 2021 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[YoutubeBridge] Fix bridge #2208

[YoutubeBridge] Fix bridge #2208

csisoap commented Jul 10, 2021 •

edited

Loading

em92 left a comment

em92 Jul 12, 2021

csisoap Jul 13, 2021

em92 commented Jul 13, 2021

em92 Jul 13, 2021

csisoap commented Jul 14, 2021

csisoap commented Jul 14, 2021

em92 commented Jul 20, 2021

csisoap commented Jul 28, 2021

em92 commented Jul 28, 2021

csisoap commented Jul 28, 2021

em92 commented Sep 5, 2021

csisoap commented Sep 6, 2021 •

edited

Loading

em92 left a comment

csisoap commented Sep 9, 2021

em92 commented Sep 11, 2021

[YoutubeBridge] Fix bridge #2208

[YoutubeBridge] Fix bridge #2208

Conversation

csisoap commented Jul 10, 2021 • edited Loading

em92 left a comment

Choose a reason for hiding this comment

em92 Jul 12, 2021

Choose a reason for hiding this comment

csisoap Jul 13, 2021

Choose a reason for hiding this comment

em92 commented Jul 13, 2021

em92 Jul 13, 2021

Choose a reason for hiding this comment

csisoap commented Jul 14, 2021

csisoap commented Jul 14, 2021

em92 commented Jul 20, 2021

csisoap commented Jul 28, 2021

em92 commented Jul 28, 2021

csisoap commented Jul 28, 2021

em92 commented Sep 5, 2021

csisoap commented Sep 6, 2021 • edited Loading

em92 left a comment

Choose a reason for hiding this comment

csisoap commented Sep 9, 2021

em92 commented Sep 11, 2021

csisoap commented Jul 10, 2021 •

edited

Loading

csisoap commented Sep 6, 2021 •

edited

Loading