Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PokemonTV] New complete bridge #2219

Merged
merged 3 commits into from
Sep 5, 2021
Merged

[PokemonTV] New complete bridge #2219

merged 3 commits into from
Sep 5, 2021

Conversation

Bockiii
Copy link
Contributor

@Bockiii Bockiii commented Jul 22, 2021

Greetings

following up on #2214 , I rebuilt the bridge using the API in order to get all languages and the filters working.

This bridge will pull all available episodes and movies from pokemon TV for a given language. It will return a link and preview image to watch the episode/movie online. It also provides a download link.

Optional filters are for series names (it will filter for part of the name and is case insensitive. filtering for "ultra" will show entries for "Pokémon the Series: Sun & Moon—Ultra Legends" and "Pokémon the Series: Sun & Moon—Ultra Adventures") and for series seasons (exact filter. searching for "2" will only show episodes of season "2", not "12" or "20").

Tested for all languages and filters.

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 22, 2021

Preview images:

image

image

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 22, 2021

Hi,

  • Link name: Yes, that's possible. I didn't do it because I didn't want to have super long entries. "Sinnoh’s Sensational First Partner Pokémon - S13E22 Pokémon: Twilight Wings—The Gathering of Stars" is quite a handful for the name of a feed item. My assumption was that S00E00 would be enough, but sure, thats possible. Do you want the change?
  • Bridge Name: I will take a look at that. the problem is: Your filter could be just something like "ultra" or "original". Then the bridge name would be "PokemonTV sensation Season 1" or so, not "PokemonTV - Sinnoh's Sensational First Partner Pokemon - Season 01". I don't derive the actual series names, I just filter the search word. So judging that the effort is pretty significant to get "something" sensible in the headline and then still not being "great", I would rather pass on that.
  • Embedding: The image is the link to the original pokemontv link. As far as I understand, the download link is the episode in 480p, while the actual streaming site goes further up to 720 or 1080. So the download link is really just a bonus (and came to me as a last minute 'meh, let me throw that in as well') and should probably not be used to actually watch the episode. Use the link on the image for that.

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 23, 2021

I don't see the benefit in embedding it. Who would rather watch the episode in a 320*240 embedded window in a feed reader than clicking on the icon and then have a full hd, fullscreen version with subtitle management and everything.

So I wouldn't change anything about the embedding. I think it's a feature that sounds good on the surface but is unusable as soon as you actually use it.

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 24, 2021

No filter, return all series and all episodes.

My version:
image

Your version:

image

And it was still loading, even though it didnt download any more data, so no idea whats going on, but Firefox sure didnt like it.

So can we not do the embedding?

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 25, 2021

Your bridge in chrome (check the error message):

image

And another "option" on the front just complicates the bridge even more (it already has 2 free text filters).

So since I don't know how feed readers will react to the embedding (firefox loads around 300 mb, chrome and edge show an error message and so on, I have no idea how any of the 1000 different feed readers will react to embedded videos), I would not add an embedded video.

So, a "no" to the embedding for me. If you want to add it as a PR afterwards, the rssbridge team can decide if it's worth the risk, but I wouldn't want to do that.

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 26, 2021

So @em92 I think you can add the bridge

@em92
Copy link
Contributor

em92 commented Aug 10, 2021

@Bockiii
Copy link
Contributor Author

Bockiii commented Aug 30, 2021

@em92 still open ;)

@em92 em92 merged commit 3249326 into RSS-Bridge:master Sep 5, 2021
@em92
Copy link
Contributor

em92 commented Sep 5, 2021

gj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants