Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reddit] Add keyword search function #2229

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Conversation

Bockiii
Copy link
Contributor

@Bockiii Bockiii commented Jul 30, 2021

Because #2225 was borked, here is the actual solution to #2078

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 30, 2021

@AntoineTurmel @dawidsowa

I've added the feature, switched the way the bridge retrieves the posts (by using the search instead of the subreddit json) and added a sorting functionality for mixed subreddits (the current bridge shows all posts from subreddit 1 first, then all from subreddit 2 etc. The new one sorts the posts by date, no matter which subreddit it comes from.).

Any more wishes?

@dawidsowa
Copy link
Contributor

Sorry for the late reply.

I've tested it now, and it LGTM.

Thank you.

@Bockiii
Copy link
Contributor Author

Bockiii commented Aug 22, 2021

@em92 go

@em92 em92 merged commit a5d3361 into RSS-Bridge:master Aug 25, 2021
@em92
Copy link
Contributor

em92 commented Aug 25, 2021

gj @Bockiii.
Also thanks @dawidsowa for testing

@kinoushe
Copy link

This update is now censoring results, adding include_over_18=on in the search query appears to return the previous behaviour. If this could be added, at least as an option, that would be appreciated. Thanks.

@Bockiii
Copy link
Contributor Author

Bockiii commented Aug 27, 2021

Interesting. I will add it as an option

@kinoushe
Copy link

Thank you @Bockiii

@Bockiii
Copy link
Contributor Author

Bockiii commented Aug 30, 2021

@kinoushe PR created

@kinoushe
Copy link

I've tested the PR and it has solved the regression, apart from needing to manually update existing feeds due to the change in default behaviour from prior releases.

@AntoineTurmel
Copy link
Contributor

Nice work !
So multiple keywords are searched as "AND", but can you can an option for "OR" with multiple keywords ?

@Bockiii
Copy link
Contributor Author

Bockiii commented Sep 1, 2021

Hmm... I dont know.

If we want to "rebuild" the full functionality of the reddit search API, we should probably rethink how we do it. Because then we would need to support everything that is on this site: https://www.reddit.com/wiki/search

Also... can't you just add a second feed for the OR?

em92 pushed a commit that referenced this pull request Sep 4, 2021
@em92
Copy link
Contributor

em92 commented Sep 4, 2021

#2257 is accepted. No need to change feed url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants