-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reddit] Add keyword search function #2229
Conversation
I've added the feature, switched the way the bridge retrieves the posts (by using the search instead of the subreddit json) and added a sorting functionality for mixed subreddits (the current bridge shows all posts from subreddit 1 first, then all from subreddit 2 etc. The new one sorts the posts by date, no matter which subreddit it comes from.). Any more wishes? |
Sorry for the late reply. I've tested it now, and it LGTM. Thank you. |
@em92 go |
gj @Bockiii. |
This update is now censoring results, adding |
Interesting. I will add it as an option |
Thank you @Bockiii |
@kinoushe PR created |
I've tested the PR and it has solved the regression, apart from needing to manually update existing feeds due to the change in default behaviour from prior releases. |
Nice work ! |
Hmm... I dont know. If we want to "rebuild" the full functionality of the reddit search API, we should probably rethink how we do it. Because then we would need to support everything that is on this site: https://www.reddit.com/wiki/search Also... can't you just add a second feed for the OR? |
As it was working before applying #2229
#2257 is accepted. No need to change feed url |
Because #2225 was borked, here is the actual solution to #2078