[HardwareInfoBridge] Created a bridge for hardware.info #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I just noticed that the bridge works on my local pc but not on my VPS. IP ban i guess? |
em92
reviewed
Aug 4, 2021
bridges/HardwareInfoBridge.php
Outdated
| $item = parent::parseItem($feedItem); | ||
|
|
||
| //get full article | ||
| $articlePage = getSimpleHTMLDOMCached('$feedItem->link'); |
There was a problem hiding this comment.
'$feedItem->link' should be without quotes at all.
That is why bridge errors "Could not resolve host: $feedItem->link"
em92
reviewed
Aug 4, 2021
bridges/HardwareInfoBridge.php
Outdated
Comment on lines
5
to
6
| const URI = 'https://HardwareInfo.net/'; | ||
| const DESCRIPTION = 'Tech news from hardware.info (Dutch)'; |
There was a problem hiding this comment.
hardware.info or hardware.net? First does not resolve for real, second has problems with certificate.
There was a problem hiding this comment.
https://hardware.info/ , which redirects to https://nl.hardware.info/
i put the wrong value in URI
|
gj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bridge that fetches the newest articles from https://hardware.info, a Dutch site about computer hardware and consumer electronics.
The bridge expands from the official RSS feed, which doesn't offer full articles.