[LegoIdeasBridge] Add bridge #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR ! We just need to get the code lints fixed, and we can merge. Moreover, please do not modify the README. It is modified by maintainers at every release. |
|
Can someone help, here? |
|
Can you try to rebase on master ? The problem might be because of the recent update to the Github Action configuration. |
|
Didn't change anything. 😔 |
|
Success! This function was the problem: public function getIcon(){
$html = getSimpleHTMLDOM(self::URI);
return $html->find('link[rel=icon]', 3)->attr['href'];
}I have no idea what's wrong, here. However, I don't think it is needed anyway, so: ready to merge! 👍 |
|
Perfect ! I don't quite understand the problem too... |
floviolleau
pushed a commit
to floviolleau/rss-bridge
that referenced
this pull request
Jan 25, 2022
* [LegoIdeasBridge] Add bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.