[NordbayernBridge] add author & timestamp of article #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix linting and this: Notice: Trying to get property 'plaintext' of non-object in /var/www/rss-bridge/pr2309/bridges/NordbayernBridge.php on line 85 (do not pay attention to error on line 105) |
|
Looks good to me. I tested locally and it is now correctly parsing date and author. On an unrelated note: im getting this image inside all feed items, sometimes duplicates. Can op please double check this weird behaviour? |
Kwbmm
pushed a commit
to Kwbmm/rss-bridge
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches author & timestamp of articles.
Also fixes two minor typos.
If there's a better way of achieving this, please let me know. Literally never used PHP before.