-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GBAtemp] Fix content extraction (#2313) #2314
Conversation
Bridge was broken since GBAtemp's Xenforo 2 upgrade on 2021-09-23
Just in case you did not see, I implemented the requested changes. No rush if you are busy, take your time. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and it's not working for me. Im getting Call to undefined function str_ends_with()
. This function is not available until php8.
Ah I see. I'm not good with git. Am I supposed to merge master back into your checked out pull request? |
My repo does not have the backport either. |
I tested this bridge locally in master branch and it works fine. Thank you @ORelio |
@em92 Would you mind merging this? Please? 😇 |
gj! |
Thanks! ❤️ |
Bridge was broken since GBAtemp's Xenforo 2 upgrade on 2021-09-23
Bridge was broken since GBAtemp's Xenforo 2 upgrade on 2021-09-23
https://gbatemp.net/threads/gbatemp-is-now-in-temporary-mode.594316/
This PR aims to fix content extraction for News, Reviews, Tutoral and Forum content.