Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GBAtemp] Fix content extraction (#2313) #2314

Merged
merged 4 commits into from
Jan 29, 2022
Merged

[GBAtemp] Fix content extraction (#2313) #2314

merged 4 commits into from
Jan 29, 2022

Conversation

ORelio
Copy link
Contributor

@ORelio ORelio commented Oct 29, 2021

Bridge was broken since GBAtemp's Xenforo 2 upgrade on 2021-09-23
https://gbatemp.net/threads/gbatemp-is-now-in-temporary-mode.594316/
This PR aims to fix content extraction for News, Reviews, Tutoral and Forum content.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Bridge was broken since GBAtemp's Xenforo 2 upgrade on 2021-09-23
bridges/GBAtempBridge.php Outdated Show resolved Hide resolved
bridges/GBAtempBridge.php Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ORelio ORelio requested a review from em92 October 31, 2021 17:35
@ORelio
Copy link
Contributor Author

ORelio commented Nov 9, 2021

Just in case you did not see, I implemented the requested changes. No rush if you are busy, take your time. 😉

Copy link
Contributor

@dvikan dvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it's not working for me. Im getting Call to undefined function str_ends_with(). This function is not available until php8.

@ORelio
Copy link
Contributor Author

ORelio commented Nov 28, 2021

You need to update your RSS-Bridge setup. @em92 backported that function in #2318

@dvikan
Copy link
Contributor

dvikan commented Nov 28, 2021

Ah I see. I'm not good with git. Am I supposed to merge master back into your checked out pull request?

@ORelio
Copy link
Contributor Author

ORelio commented Nov 28, 2021

My repo does not have the backport either.
To test the bridge, install RSS-Bridge from the main repo, and copy my version of the bridge in the bridges folder.

@dvikan
Copy link
Contributor

dvikan commented Nov 28, 2021

I tested this bridge locally in master branch and it works fine. Thank you @ORelio

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ORelio
Copy link
Contributor Author

ORelio commented Jan 27, 2022

@em92 Would you mind merging this? Please? 😇

@em92 em92 merged commit c1c998d into RSS-Bridge:master Jan 29, 2022
@em92
Copy link
Contributor

em92 commented Jan 29, 2022

gj!

@ORelio
Copy link
Contributor Author

ORelio commented Jan 29, 2022

Thanks! ❤️

@ORelio ORelio deleted the patch-4 branch January 29, 2022 14:34
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Bridge was broken since GBAtemp's Xenforo 2 upgrade on 2021-09-23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants