Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nordbayern banner #2326

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Conversation

theScrabi
Copy link
Contributor

This time: Fix the banner URL, since bridge at the moment is just returning a placeholder image.

@theScrabi theScrabi force-pushed the fix_nordbayern_banner branch from edf63f9 to 2d0733c Compare November 6, 2021 08:45
@em92 em92 merged commit 4237907 into RSS-Bridge:master Nov 6, 2021
@em92
Copy link
Contributor

em92 commented Nov 6, 2021

Found those notices after I merged your PR:

Notice: Undefined offset: 1 in /var/www/rss-bridge/pr2326/bridges/NordbayernBridge.php on line 103

https://feed.eugenemolotov.ru/pr2326/?action=display&bridge=Nordbayern&region=bad-windsheim&format=Html

@theScrabi
Copy link
Contributor Author

Hm... thx :)

@theScrabi theScrabi deleted the fix_nordbayern_banner branch December 24, 2021 13:15
floviolleau pushed a commit to floviolleau/rss-bridge that referenced this pull request Jan 25, 2022
* make banner images show for nordbayern again
* make author portrait not apear as article banner for nordbayern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants