[RadioMelodieBridge] Fix to use the new website layout #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The website layout has been slightly updated, so the bridge needed to be adapted.
dvikan
reviewed
Nov 28, 2021
There was a problem hiding this comment.
Tested locally and the bridge is repaired. However the parsing of the publish date is broken. Im getting:
Notice: Trying to access array offset on value of type bool in /home/rssbridge/public/bridges/RadioMelodieBridge.php on line 69
and the offending code is:
preg_match('/([a-z]{4,10} [0-9]{1,2} [a-z]{4,10} [0-9]{4} à [0-9]{2}:[0-9]{2})/ms', $dateHTML, $matches);
$dateText = $matches[1];
$dateArray = strptime($dateText, $dateFormat);
https://www.php.net/manual/en/function.strptime.php:
Warning
This function has been DEPRECATED as of PHP 8.1.0. Relying on this function is highly discouraged.
The regex is working fine but the strptime() does not like the input and returns false.
Remove the function strptime which will is deprecated in PHP 8.1 and replace it with the function date_parse_from_format
Coding style policy fixes !
|
I tested your change and now it works perfectly. Thank you @sysadminstory |
|
As |
Two date issues fixed ! The regular eexpression did not match days with one digit (because the day is always printed with two caracters, with a leading space), and did not match months with accented characters like 'décembre'. The date 'translate' function had a wrong placed duplicate for 'november' in the '$replace_en' array, which leaded to a wrong date conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website layout has been slightly updated, so the bridge needed to be adapted.