[FlashbackBridge] Add new bridge #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvikan changes since previous code. |
|
You can add commits to a pull request rather than opening a new one. You seem to have added an additional bridgere my mistake here. |
dvikan
approved these changes
Nov 29, 2021
|
gj! |
somini
reviewed
Jan 4, 2022
| $item['post_nr'] = $element->find('div.post-heading a strong', 0)->innertext; | ||
| $item['timestamp'] = strtotime( | ||
| str_replace( | ||
| array('Igår', 'Idag'), array('yesterday', 'today'), \ |
There was a problem hiding this comment.
This trailing \ is a syntax error on PHP 8.
[Tue Jan 4 22:54:11 2022] [::1]:57496 [200]: GET / - syntax error, unexpected token "\", expecting ")" in rss-bridge/bridges/FlashbackBridge.php on line 141
$ php --version
PHP 8.0.14 (cli) (built: Dec 17 2021 14:16:47) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.14, Copyright (c) Zend Technologies
There was a problem hiding this comment.
+1, was going to report this as well.
There was a problem hiding this comment.
Oh, this is already fixed in #2405, never mind.
floviolleau
pushed a commit
to floviolleau/rss-bridge
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new bridge for Swedish forum.
https://www.flashback.org/