Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AlfaBankByBridge] new bridge for alfabank.by #2349

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

lassana
Copy link
Contributor

@lassana lassana commented Nov 30, 2021

No description provided.

@lassana lassana marked this pull request as ready for review November 30, 2021 10:52
Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Приветствую!

Помимо перечисленных замечаний, просьба линты поправить: https://github.com/RSS-Bridge/rss-bridge/runs/4469241414?check_suite_focus=true

bridges/AlfaBankByBridge.php Outdated Show resolved Hide resolved
bridges/AlfaBankByBridge.php Outdated Show resolved Hide resolved
@lassana
Copy link
Contributor Author

lassana commented Dec 19, 2021

Поправил код и линты

@lassana lassana requested a review from em92 December 19, 2021 11:58
@dvikan
Copy link
Contributor

dvikan commented Mar 29, 2022

@lassana This PR still good? Perhaps add an english description.

@lassana
Copy link
Contributor Author

lassana commented Mar 30, 2022

@dvikan the PR is still valid, I'll update the description soon.

@Bockiii
Copy link
Contributor

Bockiii commented Apr 5, 2022

LGTM. Russian labels on a russian news site is fine by me. Bridge works as intended, with full details and without.

@Bockiii Bockiii merged commit b24cdd4 into RSS-Bridge:master Apr 5, 2022
@dvikan
Copy link
Contributor

dvikan commented Jun 5, 2022

@lassana https://www.alfabank.by down?

@lassana
Copy link
Contributor Author

lassana commented Jun 5, 2022

@dvikan works for me
Screenshot 2022-06-05 at 09-13-45 AlfaBank by Новости

@dvikan
Copy link
Contributor

dvikan commented Jun 5, 2022

Thanks. It's up for me now. It was actually down yesterday.

Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants