[AutoJMBridge] Rework of the script to handle the new website #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The brand - model page does not have filters now, so the actual feed using this bridge are broken. Website has changed. The new website offers a new search function with many more filter. So I switched to this new search page for this bridge.
|
For some reason phpunit7 stopped running. Previous attempt could not run phpunit for 44(!) minutes https://github.com/RSS-Bridge/rss-bridge/runs/4633946789?check_suite_focus=true |
em92
suggested changes
Dec 26, 2021
There was a problem hiding this comment.
Hi, @sysadminstory!
Please fix code below. Don't mention phpunit7 errors.
Remove unnecessary returnServerError() after the getContents() and getSimpleHTMLDOMCached() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brand - model page does not have filters now, so the actual feed
using this bridge are broken.
Website has changed. The new website offers a new search function with
many more filter. So I switched to this new search page for this bridge.
Fixes #2372