[MangaDexBridge] Add new bridge #2583
Conversation
Pull request artifacts
|
|
either default or examplevalue, not both :) |
|
Why? |
|
Only one is displayed in the bridge config preview anyways. examplevalue would be grey-text, default prefilled, so it cant display both at the same time. |
|
Only one is displayed at a time, but they both serve a distinct purpose. The defaultValue allows the user to quickly get a feed, while the exampleValue gives the user additional context about the parameter format. |
|
Oh, so you mean in order to see the examplevalue, a user would have to delete the default value and see what grey text comes up? Hmm.. never thought of that use case... Does it happen like that in the bridge view? |
|
It does for me. Also, exampleValue corresponds to input hint (not editable by user), while defaultValue is the input value. |
|
I decided to remove the default value and use it only on my own instance,
because the default should be all languages shown. I will commit the change
when I can.
Somewhat off topic for the pr: maybe there should be a way to override
default values from the instance config. Use cases:
1. An instance that wants to limit bandwidth, so defaults to excluding
images in the bridges that offer that option
2. Locale specific instance that defaults to a certain language if the
option is provided in a bridge
3. My use case - single user instances that are personalized
…On Thu, Mar 31, 2022, 4:16 PM Bocki ***@***.***> wrote:
Oh, so you mean in order to see the examplevalue, a user would have to
delete the default value and see what grey text comes up?
Hmm.. never thought of that use case... Does it happen like that in the
bridge view?
—
Reply to this email directly, view it on GitHub
<#2583 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6JWRFJDVGZR6JCWTC7HUTVCYB2XANCNFSM5SGFZKFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
That idea you basically be a forced-bridge-setting. Not a bad idea in general but would require some major changes. I also think that there would be a limit user scope for that. I would have to say "yes, you can use bridge XY by whitelisting it, but you can only retrieve a maximum of 5 items per feed and only in french". Also: I've never tested this, just assumed: Since all image links are sourced from the actual source, not your bridge host, isnt the bandwith minimal? Your host is not providing the image, it just tells your feed reader where it can retrieve it from. I will merge the PR in this state. The other thing is a discussion on its own. You can open a discussion threat for it if you want. |
MangaDex removed RSS feeds about 1 year ago when they took down the website and rewrote it to completely depend on javascript. They have promised to add RSS feeds though it has remained 'low priority' for all this time. This is a bridge that returns chapter updates to a manga title, but I may extend it in a future PR to allow for other things, such as following a group or specific search parameters.