Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MixcloudBridge] switch to using API #2591

Merged
merged 4 commits into from
Apr 3, 2022

Conversation

quickwick
Copy link
Contributor

Instead of parsing HTML (which apparently is no longer possible), make use of the public API.

Closes #1730

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

Pull request artifacts

file last change
MixCloud-current-context1 2022-04-03, 07:51:05
MixCloud-pr-context1 2022-04-03, 07:51:05

@yamanq
Copy link
Contributor

yamanq commented Apr 2, 2022

I don't understand what the api returns. Try this user: benpurpsoul (no items from api, even though the user seems to have items)

I get an error in RSS-Bridge for this username: công-nguyễn9

@quickwick
Copy link
Contributor Author

I don't understand what the api returns. Try this user: benpurpsoul (no items from api, even though the user seems to have items)

I have switched the bridge to use different API endpoints. The output should be better now.

I get an error in RSS-Bridge for this username: công-nguyễn9

I suspect this has something to do with how the getContents function is dealing with the special characters in that username. I'd need someone with more PHP knowledge to weigh in here. All I know is when I'm testing the API endpoints in Python (easier for me than PHP) there's no problem with querying the API with that particular username.

@dvikan dvikan merged commit a5eb02d into RSS-Bridge:master Apr 3, 2022
@quickwick quickwick deleted the MixcloudBridge branch April 4, 2022 19:31
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
* switch to using public API

* switch to different API endpoints

* fix: urlencode username

Co-authored-by: Dag <me@dvikan.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MixCloud now using React.js - react-root is empty in DOM
3 participants