[npci] Adds new NPCI Bridge #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request artifacts
|
|
Tested. The first one returns zero. The next two returns results. Looks good. |
dvikan
reviewed
Apr 28, 2022
|
|
||
| public function getURI(){ | ||
| $product = $this->getInput('product'); | ||
| return $product ? sprintf('%s/what-we-do/%s/%s', self::URI, $product, self::URL_SUFFIX[$product]) : self::URI; |
There was a problem hiding this comment.
I'd use a proper if here. It's hard to read.
senrou
added a commit
to senrou/rss-bridge
that referenced
this pull request
Apr 29, 2022
[npci] Adds new NPCI Bridge (RSS-Bridge#2651)
|
It only checks for current year, so a few products return zero results. http://rss-bridge.org/bridge01/?action=display&bridge=Npci&product=upi&format=Html works for eg. |
Kwbmm
pushed a commit
to Kwbmm/rss-bridge
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple bridge to track public circulars for various NPCI Products.
This only returns circulars against the current year, so a few products currently return zero circulars. Currently supports tracking the following pages: