Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SlusheBridge] New bridge #2700

Merged
merged 2 commits into from
Jun 4, 2022
Merged

[SlusheBridge] New bridge #2700

merged 2 commits into from
Jun 4, 2022

Conversation

quickwick
Copy link
Contributor

New bridge, still testing.

First, would be good to know if it's working for others (not generating Cloudflare error).

I also need help figuring out how to properly deal with the long string on lines 107/108 so that phpcs stops complaining about the "unnecessary" string concat. Everything I've tried seems to fail, and then I get Cloudflare error.

@github-actions
Copy link

github-actions bot commented May 7, 2022

Pull request artifacts

file last change
Slushe-pr-context1 2022-05-08, 05:18:13
Slushe-pr-context2 2022-05-08, 05:18:13
Slushe-pr-context3 2022-05-08, 05:18:13

@dvikan
Copy link
Contributor

dvikan commented May 8, 2022

All three contexts worked for me on the first try. Please try to find SFW example values. Regarding the line length you can do this:

		$userAgentParts = [
			'Mozilla/5.0 (Windows NT 10.0; Win64; x64) ',
			'AppleWebKit/537.36(KHTML, like Gecko) ',
			'Chrome/100.0.4896.147 Safari/537.36'
		];
		$implode = implode('', $userAgentParts);

I think having a hard limit on line length is silly for a small project like this. It's more for larger organizations where developers are incompetent or dont behave.

@quickwick
Copy link
Contributor Author

All three contexts worked for me on the first try.

Excellent.

Please try to find SFW example values.

I mean... the entire purpose of this site is NSFW content. I feel I've used the most SFW example values possible.

Regarding the line length you can do this:

		$userAgentParts = [
			'Mozilla/5.0 (Windows NT 10.0; Win64; x64) ',
			'AppleWebKit/537.36(KHTML, like Gecko) ',
			'Chrome/100.0.4896.147 Safari/537.36'
		];
		$implode = implode('', $userAgentParts);

Thanks! Needed to include 'user-agent: ' at the start of the first string in the parts array, but that did it.

I'm going to make some improvements to the output html, and then switch this over to a regular pull request.

@quickwick quickwick marked this pull request as ready for review May 8, 2022 05:18
@dvikan dvikan merged commit 3b04e31 into RSS-Bridge:master Jun 4, 2022
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
@quickwick quickwick deleted the SlusheBridge branch July 1, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants