Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitlabIssueBridge] Add bridge #2760

Merged
merged 14 commits into from
Jun 4, 2022
Merged

Conversation

Mynacol
Copy link
Contributor

@Mynacol Mynacol commented May 29, 2022

This bridge provides content for GitLab issues and merge requests, similar to the GithubIssueBridge.

Runs smoothly for ~two weeks for me.

@github-actions
Copy link

github-actions bot commented May 29, 2022

Pull request artifacts

file last change
GitlabIssue-pr-context1 2022-06-04, 21:30:41
GitlabIssue-pr-context2 2022-06-04, 21:30:41

@dvikan
Copy link
Contributor

dvikan commented Jun 4, 2022

gitlab has really good feeds so I assume they don't include issue and merge comments in their feed?

Move the collectData method to the top. Inline those class constants that are used to build urls. Why do manual caching inside the bridge when the entire bridge output is cached?

@Mynacol
Copy link
Contributor Author

Mynacol commented Jun 4, 2022

gitlab has really good feeds so I assume they don't include issue and merge comments in their feed?

Exactly. They just don't have feeds for individual issues/MRs.

The issues should be resolved (see the last three commits).
I moved collectData to a sensible place IMO.
I removed the manual caching, as it is not needed here.

I additionally rebased everything on master.

@dvikan dvikan merged commit 3f896f9 into RSS-Bridge:master Jun 4, 2022
@dvikan
Copy link
Contributor

dvikan commented Jun 4, 2022

The collectData method should be at the top because it is usually the first method you want to read. The parseMRDescription() should be renamed to parseMergeRequestDescription. getProjectURI() should be inlined. I did some testing with gitlab.gnome.org and GNOME/gnome-shell. It's good. Thanks.

Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
* [GitlabIssueBridge] new bridge

This tracks issue comments on arbitrary gitlab projects.

* [GitlabIssueBridge] Prepare for Merge Request support + fixes

- Proper UIDs
- Default bridge name fixed
- Fix cache identifiers
- Add TODOs

* [GitlabIssueBridge] creation timestamp preferred

And prefer original author over editor.

* [GitlabIssueBridge] Do not add date to item title

Prettier without it.

* [GitlabIssueBridge] Support Merge Requests

This bridge can now generate feeds for Merge Requests.

* [GitlabIssueBridge] typo

* [GitlabIssueBridge] Fix Img src attr in comments

* [GitlabIssueBridge] Fix function call

* [GitlabIssueBridge] Fix test

Use gitlab.com if no h parameter was given.
Fixes a phpunit test.

* [GitlabIssueBridge] linting

* [GitlabIssueBridge] Add MR support to description

* [GitlabIssueBridge] Move function collectData

* [GitlabIssueBridge] rm single-use class constants

* [GitlabIssueBridge] Remove manual caching

Just depend on rss-bridges built-in caching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants