[GolemBridge] Remove image galleries #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add all images of the image gallery, but only the preselected one. Often, the same gallery is used multiple times with different preselected images. The previous implementation always added all images of the gallery, cluttering the article. This patch only adds the preselected one. The no-js link wrapping around the gallery leads to a 403 Forbidden page, so linking that doesn't work to really support galleries.
Pull request artifacts
|
Kwbmm
pushed a commit
to Kwbmm/rss-bridge
that referenced
this pull request
Jun 17, 2022
Do not add all images of the image gallery, but only the preselected one. Often, the same gallery is used multiple times with different preselected images. The previous implementation always added all images of the gallery, cluttering the article. This patch only adds the preselected one. The no-js link wrapping around the gallery leads to a 403 Forbidden page, so linking that doesn't work to really support galleries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add all images of the image gallery, but only the preselected one.
Often, the same gallery is used multiple times with different preselected
images. The previous implementation always added all images of the
gallery, cluttering the article. This patch only adds the preselected one.
The no-js link wrapping around the gallery leads to a 403 Forbidden
page, so linking that doesn't work to really support galleries.