Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuronewsBridge] Add bridge #2786

Merged
merged 3 commits into from
Jun 7, 2022
Merged

[EuronewsBridge] Add bridge #2786

merged 3 commits into from
Jun 7, 2022

Conversation

SqrtMinusOne
Copy link
Contributor

A bridge for the "Just In" feed of Euronews

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Pull request artifacts

file last change
Euronews-pr-context1 2022-06-07, 08:51:37

@yamanq yamanq self-requested a review June 6, 2022 23:57
Copy link
Contributor

@yamanq yamanq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this detailed bridge! Please fix the minor changes requested and I will merge this.

Optionally, consider implementing some additional functions to improve the bridge:

  • getURI to link to the language specific page
  • getName (Ex: 'Euronews English')

bridges/EuronewsBridge.php Outdated Show resolved Hide resolved
bridges/EuronewsBridge.php Show resolved Hide resolved
bridges/EuronewsBridge.php Outdated Show resolved Hide resolved
bridges/EuronewsBridge.php Outdated Show resolved Hide resolved
@yamanq yamanq merged commit 53f9970 into RSS-Bridge:master Jun 7, 2022
@yamanq
Copy link
Contributor

yamanq commented Jun 7, 2022

Nice job!

Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants