Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 2022-06-14 #2818

Merged
merged 1 commit into from
Jun 14, 2022
Merged

[Release] 2022-06-14 #2818

merged 1 commit into from
Jun 14, 2022

Conversation

yamanq
Copy link
Contributor

@yamanq yamanq commented Jun 13, 2022

This is the preparation for the release. The release notes are in the draft release. I will tag and publish the release on June 14 after merging any leftover PRs from #2657, but it would be better if you could review them first.

@yamanq yamanq requested review from dvikan and Bockiii June 13, 2022 07:01
@Bockiii
Copy link
Contributor

Bockiii commented Jun 13, 2022

Do we want to change the contributors approach? Tbh, I find it cluttered and the manual part about it annoys me a lot.

This can be implemented in 10 minutes, will be updated automatically, will be in an additional file other than the readme and looks nice.

https://github.com/marketplace/actions/contribute-list
This is the result
https://github.com/akhilmhdh/contributors-readme-action/blob/master/contributors.md

@yamanq
Copy link
Contributor Author

yamanq commented Jun 13, 2022

I would prefer that contributors are listed in the readme. We could find a way to automate it, but running a script every few months seems ok to me. In any case, I think that discussion deserves its own issue, as the approach you linked also has benefits.

@Bockiii
Copy link
Contributor

Bockiii commented Jun 13, 2022

I still think it doesnt belong in the readme. I dont know any other application (that doesnt have like 5 contributors) that does it like this. Its almost 60% of the whole readme (203 lines out of 346). We could also clean up the rest a bit.

I dont know if the rant for example still has it's value. It was written by sebsauvage 9 years ago. We are currently using APIs in many bridges and I for one prefer the api usage (if the content is still reasonably complete).

@VerifiedJoseph
Copy link
Contributor

The authors list seems redundant given that GitHub has a fancy (and auto-updating) contributors page. I'd keep the authors section but remove the list and just link to contributors.

Or, what @Bockiii suggested:

This can be implemented in 10 minutes, will be updated automatically, will be in an additional file other than the readme and looks nice.

https://github.com/marketplace/actions/contribute-list This is the result https://github.com/akhilmhdh/contributors-readme-action/blob/master/contributors.md

@yamanq
Copy link
Contributor Author

yamanq commented Jun 13, 2022

You're right, I never realized how long it was. Let's revamp the README after this release. I disagree that we should completely remove the contributors. We can still link to a formatted file like the one @Bockiii shared.

@yamanq yamanq merged commit 9503f9a into RSS-Bridge:master Jun 14, 2022
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants