fix: force HTTP 1.1 in curl requests #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em92
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
This is correct PR. We need to make ensure, that curl uses same protocol version for http requests without depending of curl version.
Quoting https://stackoverflow.com/a/59955444
Since curl 7.62.0 the default option is: CURL_HTTP_VERSION_2TLS
Before that the default used to be: CURL_HTTP_VERSION_1_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure on this one because I'm unfamiliar with HTTP/2. But it does fix #2947.