Add DeutscheWelle FeedExpander bridge. #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolby33
force-pushed
the
deutsche-welle
branch
from
500d4d1 to
fc80ae9
Compare
Pull request artifacts
|
|
looks kinda slow but if it works it works |
dvikan
reviewed
Sep 15, 2023
|
|
||
| $parsedUrl = parse_url($item['uri']); | ||
| unset($parsedUrl['query']); | ||
| $url = $this->unparseUrl($parsedUrl); |
There was a problem hiding this comment.
not quite sure why parse and unparse url here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a FeedExpander bridge for the Deutsche Welle RSS feeds from
This is my first time working with PHP, so please let me know any mistakes I may have made. I based this approach mostly on the ZeitBridge.