Load a config file from environment variable #3842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable RSSBRIDGE_CONFIG, if set, is used as file path instead of the default config.ini.php in the document root. This allows having a read-only document root and still setting custom configuration options. In particular, this helps NixOS which patched the code previously. https://github.com/NixOS/nixpkgs/blob/23.11/pkgs/servers/web-apps/rss-bridge/paths.patch
|
i dont like this because the config logic is already very complex. this issue is related to prior efforts to split out a public document root. |
|
I'd argue this PR doesn't complicate the config architecture by much. But I see your point.
Is there a sane existing method to pass configuration values to rss-bridge without placing/modifying a file in the document directory? I only know the environment variables as a possible solution, but that seems error-prone and not so elegant to me. Still maybe I'll try to do that and see how far I come.
|
|
What is the purpose of this? Can this problem be solved with a symlink? Example: |
12 tasks
|
The environment variable method is working quite nicely, so this is not needed anymore :) Edit: reference to the other PR: NixOS/nixpkgs#223148 |
SuperSandro2000
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Apr 3, 2024
This allows managing rss-bridge's config with nix. It leverages the environment variable way of setting the config options, introduced quite [some time ago](RSS-Bridge/rss-bridge#2100) It is the only existing way to set config options independent of the document root, and upstream is [hesitant](RSS-Bridge/rss-bridge#3842) to change the config loading methods. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable RSSBRIDGE_CONFIG, if set, is used as file path instead of the default config.ini.php in the document root. This allows having a read-only document root and still setting custom configuration options. In particular, this helps NixOS which patched the code previously (ref https://github.com/NixOS/nixpkgs/blob/23.11/pkgs/servers/web-apps/rss-bridge/paths.patch ).
An alternative would be setting the config options as environment variables. But coercing arrays in comma-separated lists and escaping special symbols can easily lead to errors. Using an ini file is easier for NixOS (see NixOS/nixpkgs#223148 if you're interested).