New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FirefoxReleaseNotesBridge] Add New Bridge #3930

Merged

dvikan merged 2 commits into RSS-Bridge:master from tillcash:master

Jan 27, 2024

Contributor

tillcash commented Jan 26, 2024

I'm uncertain about the reasons for the failed checks.


          [FirefoxReleaseNotesBridge] Add New Bridge

4371e57

I'm uncertain about the reasons for the failed checks.

Contributor

dvikan commented Jan 26, 2024

same.

@User123698745 @ORelio

Contributor

ORelio commented Jan 26, 2024

I'm not sure how the PR Testing actually works but having a quick look, it seems like it fails to parse the HTML listing for 'Platform' argument of FirefoxReleaseNotesBridge:

rss-bridge/.github/prtester.py

Line 91 in d822d66

if 'optgroup' in option.name:

Run mkdir results;
FirefoxReleaseNotesBridge (pr)
Traceback (most recent call last):
  File "prtester.py", line 182, in <module>
    output_file=args.output_file
  File "prtester.py", line 27, in main
    table_rows += testBridges(instance, bridge_cards, with_upload, with_reduced_upload) # run the main scraping code with the list of bridges
  File "prtester.py", line 91, in testBridges
    if 'optgroup' in option.name:
TypeError: argument of type 'NoneType' is not iterable
Error: Process completed with exit code 1.

Maybe @User123698745 would know better than me why this happens.

Contributor

dvikan commented Jan 26, 2024 •

edited

Loading

sorry @ORelio i meant to tag @Bockiii

it is possible that this error is caused by be in a recent refactor.

User123698745 mentioned this pull request

[prtester.py] Fix: Only select actual "option" elements of "select" elements #3932

Merged

Contributor

User123698745 commented Jan 26, 2024

The script iterates thought each child element and expects them all to be an option element. Since #3924, every option now has an additional \n causing this error.

I created a PR to fix this: #3932

Contributor

dvikan commented Jan 26, 2024

@tillcash can you trigger a new ci build by adding a commit to this pr?


          Update FirefoxReleaseNotesBridge.php

8f5985c

github-actions bot commented Jan 27, 2024

Pull request artifacts

Bridge	Context	Status
FirefoxReleaseNotes	1 untitled (pr)	✔️

last change: Saturday 2024-01-27 04:49:51

Contributor Author

tillcash commented Jan 27, 2024

dvikan merged commit a15e578 into RSS-Bridge:master

7 checks passed

truecharts-admin referenced this pull request in truecharts/public


          chore(deps): update container image rssbridge/rss-bridge to v2024-02-…

ec1a8a9

…02@1a4d30c by renovate (#17967)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rssbridge/rss-bridge](https://togithub.com/RSS-Bridge/rss-bridge) |
major | `2023-09-24` -> `2024-02-02` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>RSS-Bridge/rss-bridge (rssbridge/rss-bridge)</summary>

###
[`v2024-02-02`](https://togithub.com/RSS-Bridge/rss-bridge/releases/tag/2024-02-02):
RSS-Bridge 2024-02-02

[Compare
Source](https://togithub.com/RSS-Bridge/rss-bridge/compare/2023-09-24...2024-02-02)

**Zero breaking changes**

Recommended to checkout revised installation instructions for Debian 12:


https://github.com/RSS-Bridge/rss-bridge#how-to-install-on-debian-12-nginx--php-fpm

Officially hosted instance: https://rss-bridge.org/bridge01/

IRC channel #rssbridge at https://libera.chat/

Thank you to all contributors who keeps the project alive.

#### A subset of changes which might be interesting

Rss-Bridge can now be password protected with required token in the url:

```diff
--- config.ini.php	2024-02-02 18:41:36.881743962 +0100
+++ /tmp/1	2024-02-02 18:42:00.289567705 +0100
@&#8203;@&#8203; -92,7 +92,7 @&#8203;@&#8203;
 password = ""
 
 ; Token authentication (URL)
-token = ""
+token = "hunter2"
```

- chore: add tools for manually administrating the configured cache by
[@&#8203;dvikan](https://togithub.com/dvikan) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3867](https://togithub.com/RSS-Bridge/rss-bridge/pull/3867)
- fix: only escape iframe,script and link for html output by
[@&#8203;dvikan](https://togithub.com/dvikan) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3882](https://togithub.com/RSS-Bridge/rss-bridge/pull/3882)
- \[AnnasArchiveBridge] Add new bridge by
[@&#8203;Phantop](https://togithub.com/Phantop) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3888](https://togithub.com/RSS-Bridge/rss-bridge/pull/3888)
- feat: add etag support to getContents by
[@&#8203;dvikan](https://togithub.com/dvikan) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3893](https://togithub.com/RSS-Bridge/rss-bridge/pull/3893)
- fix: add cache clearing tools by
[@&#8203;dvikan](https://togithub.com/dvikan) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3896](https://togithub.com/RSS-Bridge/rss-bridge/pull/3896)
- feat: token authentication by
[@&#8203;dvikan](https://togithub.com/dvikan) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3927](https://togithub.com/RSS-Bridge/rss-bridge/pull/3927)
- \[FirefoxReleaseNotesBridge] Add New Bridge by
[@&#8203;tillcash](https://togithub.com/tillcash) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3930](https://togithub.com/RSS-Bridge/rss-bridge/pull/3930)
- Fix Docker exec by [@&#8203;Alkarex](https://togithub.com/Alkarex) in
[https://github.com/RSS-Bridge/rss-bridge/pull/3941](https://togithub.com/RSS-Bridge/rss-bridge/pull/3941)

#### New Contributors

- [@&#8203;m3nu](https://togithub.com/m3nu) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3778](https://togithub.com/RSS-Bridge/rss-bridge/pull/3778)
- [@&#8203;itsLameni](https://togithub.com/itsLameni) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3789](https://togithub.com/RSS-Bridge/rss-bridge/pull/3789)
- [@&#8203;wpdevelopment11](https://togithub.com/wpdevelopment11) made
their first contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3793](https://togithub.com/RSS-Bridge/rss-bridge/pull/3793)
- [@&#8203;SebLaus](https://togithub.com/SebLaus) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3786](https://togithub.com/RSS-Bridge/rss-bridge/pull/3786)
- [@&#8203;knrdl](https://togithub.com/knrdl) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3800](https://togithub.com/RSS-Bridge/rss-bridge/pull/3800)
- [@&#8203;RayBB](https://togithub.com/RayBB) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3823](https://togithub.com/RSS-Bridge/rss-bridge/pull/3823)
- [@&#8203;glacasa](https://togithub.com/glacasa) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3825](https://togithub.com/RSS-Bridge/rss-bridge/pull/3825)
- [@&#8203;xz47sv](https://togithub.com/xz47sv) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3835](https://togithub.com/RSS-Bridge/rss-bridge/pull/3835)
- [@&#8203;bkidwell](https://togithub.com/bkidwell) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3843](https://togithub.com/RSS-Bridge/rss-bridge/pull/3843)
- [@&#8203;xduugu](https://togithub.com/xduugu) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3854](https://togithub.com/RSS-Bridge/rss-bridge/pull/3854)
- [@&#8203;tillcash](https://togithub.com/tillcash) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3862](https://togithub.com/RSS-Bridge/rss-bridge/pull/3862)
- [@&#8203;crisukbot](https://togithub.com/crisukbot) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3877](https://togithub.com/RSS-Bridge/rss-bridge/pull/3877)
- [@&#8203;hleskien](https://togithub.com/hleskien) made their first
contribution in
[https://github.com/RSS-Bridge/rss-bridge/pull/3920](https://togithub.com/RSS-Bridge/rss-bridge/pull/3920)

**Full Changelog**:
RSS-Bridge/rss-bridge@2023-09-24...2024-02-02

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzIuNCIsInVwZGF0ZWRJblZlciI6IjM3LjE3Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet