[prtester.py] Fix: Only select actual "option" elements of "select" elements #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements to prevent "TypeError: argument of type 'NoneType' is not iterable"
|
thanks for taking the time to fix this. |
|
awesome, thanks @User123698745 ! I was down with covid so I couldn't take a look at it but your fix looks less like a "patch it up" and more like it should have been designed that way from the beginning :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the "TypeError: argument of type 'NoneType' is not iterable" error in
prtester.py(first noticed in #3930).The script iterates thought each child element and expects them to all be an
optionelement. Since #3924, everyoptionnow has an additional\ncausing this error.With this PR the script will only iterates thought actual
optionelement.