-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InstagramEmbedBridge] Add a new Instagram Bridge based on the embed url #4060
base: master
Are you sure you want to change the base?
Conversation
This bridge is a simplified version of InstagramBridge that is based on the embed page of a profile page. It does only support the Username mode, and is limited to the last 6 medias. At least actually, it does not need any cookies, and does work from a server IP, without limitation.
Pull request artifacts
last change: Thursday 2024-04-04 21:40:30 |
Nice job. The feed works fine, but I have some issues with the media links. The embedded images/videos aren't displayed, as Instagram sends the Finally, the direct media links work, but produce a "URL signature mismatch" sometimes/after some time, which is unfortunately expected. |
I would prefer merging this change into the existing instagram bridge so that current feeds start working again. if it's too much work, im ok with merging this. i am guessing that also the embed has some form of rate limits though... |
Fully agree with you dvikan. Instagram has always been one of the main problem-bridges. If this can at least restore parts of the functionality, it will probably help 99% of the users of the old bridge and all of the instagram issues can be closed |
I can try to merge this change to the existing Instagram bridge, but I have some question about the merge :
In the case of question 2, how should the Feed reader be informed that the method used can not display some media types (stories / reels / whatever they call them) ? |
I'd opt for option 2. Use it as a fallback/alternative for the existing methods. That makes it usable for existing feeds and avoids exposing new options users might not be able to grasp.
Regarding informing users about reduced media formats: I'd just add some text in the bridge description or info boxes, but never into the feed. The exact design is still up for debate.
|
In regards to techincal debt, I always prefer to just do one thing one time. The fallback option has the benefit that the users wont have to change anything, but adds a new layer to a already complex bridge which makes it harder to maintain or grasp for possible maintainers. If you can manage to make it a sensible failover, go for option 2 I guess. I dont think an extra bridge or marker would benefit anyone. |
I've had this on my instance for a while working without issue, but it broke today. It's easily fixed by editing the regex on line 53:
For some reason, there's some weird unicode being added after NavigationMetrics and before ", which breaks it. The simple fix seems to be to remove the trailing ", as it will still match and parse correctly. |
This bridge is a simplified version of InstagramBridge that is based on the embed page of a profile page.
It does only support the Username mode, and is limited to the last 6 medias.
At least actually, it does not need any cookies, and does work from a server IP, without limitation.