Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prtester] improve prtester.py and prhtmlgenerator.yml for running in forks #4313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

User123698745
Copy link
Contributor

This PR will improve prtester.py and prhtmlgenerator.yml for running in forks. It makes the hard-coded repo name and base url to the new rss-bridge-tests repo dynamic/configurable (by using the repo owners name and an optional ARTIFACTS_REPO variable). The Upload tests job will be skipped when the secret RSSTESTER_ACTION is missing (which will always be the case for forks, by default) instead of always failing. Additional small fixes to the Upload tests job: It failed when the prs directory did not exist yet and it failed when there was no change to the html files.

add parameter "--artifact-base-url" and "--artifact-directory"
@Bockiii
Copy link
Contributor

Bockiii commented Oct 22, 2024

Thanks for all the help with this!

Because I've run into this before and maybe you know how to do it:

If you re-run the test manually within github, I've had the behavior that it cant identify the github event number (because the run wasnt caused by a commit but by a manual re-run request) and thus, the github event number defaults to "none".

I'm not sure if you can recreate that and if so, have a fallback to use something else but the github event number.

@User123698745
Copy link
Contributor Author

I could not recreate that behavior by re-running the pipeline or single jobs of the pipelines. github.event.number was always set, but to make sure I added a fallback to value none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants