Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WKYT bridge #4337

Merged
merged 1 commit into from
Nov 23, 2024
Merged

feat: add WKYT bridge #4337

merged 1 commit into from
Nov 23, 2024

Conversation

mattconnell
Copy link
Contributor

Bridge for the WKYT Lexington News site

I noticed that WKYT and WYMT had very similar news interfaces, and I was correct in guessing that I could just copy and paste this bridge with some different metadata and it would work. It occurs to me that a lot of the CBS news affiliate stations, probably most of the Gray Media affiliated sites, will be able to be handled in a very similar if not exactly the same way. In fact I just checked, after typing this, and WSAZ works exactly the same way.

Question: is it worthwhile trying to flesh out an abstract class for these? Is this something better discussed in an issue? Am I retracing someone else's steps already?

Copy link

Pull request artifacts

Bridge Context Status
WKYTNews 1 untitled (pr) Bridge returned error 0! (20048)
Type: ErrorException
Message: Attempt to read property "href" on null

last change: Thursday 2024-11-21 03:58:43

@mattconnell
Copy link
Contributor Author

Pull request artifacts

Bridge Context Status
WKYTNews 1 untitled (pr)Bridge returned error 0! (20048)
Type: ErrorException
Message: Attempt to read property "href" on null

last change: Thursday 2024-11-21 03:58:43

Hmm. I wonder if the site's hosting is blocking Github. It returned proper results when I tested it from my local network.

@dvikan dvikan merged commit 086ef7f into RSS-Bridge:master Nov 23, 2024
9 checks passed
@dvikan
Copy link
Contributor

dvikan commented Nov 23, 2024

i prefer not using inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants