WIP: Add curl library to support multiple proxies #477
Conversation
cookiejar: /tmp/rssbridge-fb-cookies.txt , make sure it is writable by web server process Unfortunately, after I implemented cookies, I found that with _fb_noscript=1, the captcha will only work for a single time. ie. the next request will require a new captcha.
Force IPv4
|
Great work! The usage of multiple Can you please split all changes done to FacebookBridge into a separate PR? |
| $proxies_str = file_get_contents(__DIR__.'/../proxylist/'.$file); | ||
| $proxies = array_merge($proxies, explode("\n", $proxies_str, -1)); | ||
| } | ||
| $proxy = $proxies[array_rand($proxies)]; |
There was a problem hiding this comment.
Will this work if no proxy is specified (no files in the 'proxylist/' directory)?
| , $stripRN | ||
| , $defaultBRText | ||
| , $defaultSpanText), | ||
| $info, $header, $proxy); |
There was a problem hiding this comment.
Is there any need to know $info, $header, $proxy?
| , $defaultSpanText), | ||
| $info, $header, $proxy); | ||
| } | ||
| ?> |
There was a problem hiding this comment.
Please have a look at the Travis-CI results. Also checkout the new contributions guidelines regarding coding style.
| } | ||
|
|
||
| return parent::getName(); | ||
| return isset($this->extraInfos['name']) ? $this->extraInfos['name'] : $this->authorName.' - Facebook Bridge'; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please split this file into a separate PR
pellaeon
changed the title
|
Hey I opened a new pull request #531 that only contains |
proxylist/for proxies, and randomly picks one to use. For the proxy URL string syntax, refer toPROXY PROTOCOL PREFIXESsection in curl manpage. Example:1.2.3.4:8080is a HTTP proxy, curl also supports SOCKS.This PR contains some commented out code, might be useful for future enhancements, so I lefted it there.
Also, if the maintainers would like to split these features into multiple PRs, I would also be happy to do that.