[IvooxBridge] new bridge for podcast plataform #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teromene
previously requested changes
Jan 11, 2018
bridges/IvooxBridge.php
Outdated
| private function ivGetSimpleHTMLDOM($url) | ||
| { | ||
| return getSimpleHTMLDOM( | ||
| $url, |
There was a problem hiding this comment.
No whitespace at end of line.
Same line 25, 26, 38, 29, 30, 31, 32, 33, 34, 60, 63, 67, 96, 109
bridges/IvooxBridge.php
Outdated
| } | ||
| } | ||
|
|
||
| private function ivBridgeAddItem($episode_link, $podcast_name, $episode_title, $author_name, $episode_description, $publication_date, $episode_duration) |
There was a problem hiding this comment.
Line too long, you can use \ followed by line return
bridges/IvooxBridge.php
Outdated
| $item['author'] = $author_name; | ||
| $item['timestamp'] = $publication_date; | ||
| $item['uri'] = $episode_link; | ||
| $item['content'] = '<a href="' . $episode_link . '">' . $podcast_name . ': ' . $episode_title . '</a><br />Duration: ' . $episode_duration . '"<br />Description:<br />' . $episode_description; |
bridges/IvooxBridge.php
Outdated
| if ($linkcount == 0) { | ||
| $episode_link = $link->href; | ||
| $episode_title = $link->title; | ||
| } |
There was a problem hiding this comment.
Space after closing bracket, same line 78, 118, 131
bridges/IvooxBridge.php
Outdated
| $episode_duration = $flipper->find('p.time', 0)->innertext; | ||
| $publication_date = $flipper->find('li.date', 0)->getAttribute('title'); | ||
|
|
||
| // alternative date_parse_from_format or DateTime::createFromFormat('G:i - d \d\e M \d\e Y', $publication); // TODO: month name translations, due funciton doesn't support locale |
There was a problem hiding this comment.
Line too long, you can use a multi-line comment
bridges/IvooxBridge.php
Outdated
| $a = strptime($publication_date, '%H:%M - %d de %b. de %Y'); // obsolete function, uses c libraries | ||
| $publication_date = mktime(0, 0, 0, $a['tm_mon'] + 1, $a['tm_mday'], $a['tm_year'] + 1900); | ||
|
|
||
| $this->ivBridgeAddItem($episode_link, $podcast_name, $episode_title, $author_name, $episode_description, $publication_date, $episode_duration); |
teromene
previously requested changes
Apr 15, 2018
bridges/IvooxBridge.php
Outdated
| @@ -42,29 +42,32 @@ private function printIfDebug($text) | |||
| } | |||
| } | |||
|
|
|||
| private function ivBridgeAddItem($episode_link, $podcast_name, $episode_title, $author_name, $episode_description, $publication_date, $episode_duration) | |||
| private function ivBridgeAddItem($episode_link, $podcast_name, $episode_title, $author_name, | |||
| $episode_description, $publication_date, $episode_duration) | |||
bridges/IvooxBridge.php
Outdated
| { | ||
| $item = array(); | ||
| $item['title'] = $podcast_name . ':' . $episode_title; | ||
| $item['author'] = $author_name; | ||
| $item['timestamp'] = $publication_date; | ||
| $item['uri'] = $episode_link; | ||
| $item['content'] = '<a href="' . $episode_link . '">' . $podcast_name . ': ' . $episode_title . '</a><br />Duration: ' . $episode_duration . '"<br />Description:<br />' . $episode_description; | ||
| $item['content'] = '<a href="' . $episode_link . '">' . $podcast_name . ': ' . $episode_title . '</a>' | ||
| . '<br />Duration: ' . $episode_duration . '"' |
There was a problem hiding this comment.
No need to concatenate '</a>' and '<br />Duration: '.
logmanoriginal
force-pushed
the
IvooxBridge
branch
from
993601b to
6b9f76c
Compare
logmanoriginal
dismissed
teromene’s stale review
I've applied the necessary fixes and made sure it works as intended
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.