[SoundcloudBridge] Improves Author, Date, Description #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Author Name now doesn't include Episode Title 2. It now fetches Episode Creation Timestamp, to allow correct sorting in podcatchers 3. Description is now the actual show notes, and not an <audio> tag Not implemented yet: fetch enclosure length, fetch enclosure mimetype, fetch artwork
|
It's not clear to me why the test fails. |
|
Thanks for the PR!
This is not your fault. Travis changed some internal specifics that currently break our checks:
I'm working on a solution... |
|
Master is fixed, please rebase. |
|
I am seeing "This branch has no conflicts with the base branch" on my side, do I still have to rebase? I was working from GitHub's web editor so far so I don't see how I can do a rebase. |
|
Ah I see, then I'll merge and fix if anything breaks. Looks good to me anyway 👍 |
|
Merged. |
|
Cheers. I'll see how else I can improve this bridge soon. |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
1. Author Name now doesn't include Episode Title 2. It now fetches Episode Creation Timestamp, to allow correct sorting in podcatchers 3. Description is now the actual show notes, and not an <audio> tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not implemented yet: fetch enclosure length, fetch enclosure mimetype, fetch artwork